[PATCH] D18901: ARM: Use a callee save register for the swiftself parameter.

[Matthias Braun via llvm-commits]

MatzeB marked an inline comment as done.

================
Comment at: lib/Target/ARM/ARMFrameLowering.cpp:914
@@ -925,1 +913,3 @@
+      bool isLiveIn = MF.getRegInfo().isLiveIn(Reg);
+      if (!isLiveIn)
         MBB.addLiveIn(Reg);
----------------
I found the codes intention is clearer if the if() condition looks at the live-in not at something called isKill. What about this new version that drops the isKill variable instead?

================
Comment at: test/CodeGen/ARM/swiftself.ll:2
@@ -3,1 +1,3 @@
+; RUN: llc -verify-machineinstrs -mtriple=armv7k-apple-ios8.0 -mcpu=cortex-a7 -o - %s | FileCheck --check-prefix=CHECK --check-prefix=OPT %s
+; RUN: llc -O0 -verify-machineinstrs -mtriple=armv7k-apple-ios8.0 -mcpu=cortex-a7 -o - %s | FileCheck %s
 
----------------
rengolin wrote:
> The CHECK prefix is still there... already assumed by default.
```
static void AddCheckPrefixIfNeeded() {
  if (CheckPrefixes.empty())
    CheckPrefixes.push_back("CHECK");
}
```
It is only default if you do not add any other check-prefixes.


Repository:
  rL LLVM

http://reviews.llvm.org/D18901