[PATCH] D18771: [lld] Add ScriptParserBase class

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 14:34:23 PDT 2016


zatrazz added inline comments.

================
Comment at: ELF/ScriptParser.cpp:16
@@ +15,3 @@
+#include "ScriptParser.h"
+#include "Driver.h"
+
----------------
ruiu wrote:
> Do you need this #include?
I do not think so, I will remove it.

================
Comment at: ELF/ScriptParser.h:21-22
@@ +20,4 @@
+public:
+  ScriptParserBase(StringRef S)
+      : Input(S), Tokens(tokenize(S)) {}
+  virtual ~ScriptParserBase() = default;
----------------
ruiu wrote:
> Please run clang-format-diff on this patch.
I will do it.


Repository:
  rL LLVM

http://reviews.llvm.org/D18771





More information about the llvm-commits mailing list