[PATCH] D18771: [lld] Add ScriptParserBase class
    Rui Ueyama via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Apr  4 14:23:29 PDT 2016
    
    
  
ruiu added inline comments.
================
Comment at: ELF/ScriptParser.cpp:16
@@ +15,3 @@
+#include "ScriptParser.h"
+#include "Driver.h"
+
----------------
Do you need this #include?
================
Comment at: ELF/ScriptParser.h:21-22
@@ +20,4 @@
+public:
+  ScriptParserBase(StringRef S)
+      : Input(S), Tokens(tokenize(S)) {}
+  virtual ~ScriptParserBase() = default;
----------------
Please run clang-format-diff on this patch.
Repository:
  rL LLVM
http://reviews.llvm.org/D18771
    
    
More information about the llvm-commits
mailing list