[PATCH] D18707: Make DIASession work if msdia*.dll isn't registered.

[Nico Weber via llvm-commits]

thakis added inline comments.

================
Comment at: lib/DebugInfo/PDB/DIA/DIASession.cpp:27
@@ +26,3 @@
+
+bool LoadDIA(CComPtr<IDiaDataSource>& DiaDataSource) {
+  if (SUCCEEDED(CoCreateInstance(CLSID_DiaSource, nullptr, CLSCTX_INPROC_SERVER,
----------------
rnk wrote:
> LLVM prefers 'static' functions to anonymous namespaces:
> http://llvm.org/docs/CodingStandards.html#anonymous-namespaces
> *shrug*
Yes, but there was already an empty unnamed namespace _right here_! It seemed like fate wanted this to be in an unnamed namespace :-)

(will change before landing)


http://reviews.llvm.org/D18707