[PATCH] D18707: Make DIASession work if msdia*.dll isn't registered.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 14:32:21 PDT 2016


rnk added inline comments.

================
Comment at: lib/DebugInfo/PDB/DIA/DIASession.cpp:27
@@ +26,3 @@
+
+bool LoadDIA(CComPtr<IDiaDataSource>& DiaDataSource) {
+  if (SUCCEEDED(CoCreateInstance(CLSID_DiaSource, nullptr, CLSCTX_INPROC_SERVER,
----------------
LLVM prefers 'static' functions to anonymous namespaces:
http://llvm.org/docs/CodingStandards.html#anonymous-namespaces
*shrug*


http://reviews.llvm.org/D18707





More information about the llvm-commits mailing list