[PATCH] D18663: Cleanup Chain Handling in X86ISelLowering

[Nirav Dave via llvm-commits]

niravd added a comment.

> Uses of any of the original chain outputs should be modified to depend on BOTH the original load, and the new load (through a TokenFactor), because I don't believe we are actually necessarily removing the original load during these transforms. That is, I think the original code was correct and necessary, as far as it went -- the issue was only that it failed to do the exact same thing for the output chains of any but the first load.


Right. Since it's duplicated there's no reason to expect them to be evaluated the same, but this would drop any WAR hazard on those just loads.


http://reviews.llvm.org/D18663