[PATCH] D18663: Cleanup Chain Handling in X86ISelLowering

[James Y Knight via llvm-commits]

jyknight added a subscriber: jyknight.
jyknight added a comment.

This looks wrong, as it's losing the *original* load from the chain now.

Uses of any of the original chain outputs should be modified to depend on BOTH the original load, and the new load (through a TokenFactor), because I don't believe we are actually necessarily removing the original load during these transforms. That is, I think the original code was correct and necessary, as far as it went -- the issue was only that it failed to do the exact same thing for the output chains of any but the first load.

Also, please reference the PR for this.


http://reviews.llvm.org/D18663