[PATCH] D18499: [ELF] - Implemented prototype of location counter support.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 09:06:27 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.h:71
@@ +70,3 @@
+  template <class ELFT>
+  void layoutSections(std::vector<OutputSectionBase<ELFT> *> S);
+  uint64_t getSecVA(StringRef Name);
----------------
And also not sure about that place. I did not use reference because I need vector to be copied. Is it ok or better to do copy manually inside ?


http://reviews.llvm.org/D18499





More information about the llvm-commits mailing list