[PATCH] D18499: [ELF] - Implemented prototype of location counter support.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 08:57:00 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:172
@@ +171,3 @@
+  ElfSym<ELFT>::End.st_value = VA;
+}
+
----------------
This will not be here (ends), I am going to prepare patch to move that like was suggested.

================
Comment at: ELF/Writer.cpp:1417
@@ +1416,3 @@
+  size_t PhdrSize = sizeof(Elf_Phdr) * Phdrs.size();
+  Out<ELFT>::ProgramHeaders->setSize(PhdrSize);
+
----------------
This also probably can be moved out for all 3 assign*() methods.


http://reviews.llvm.org/D18499





More information about the llvm-commits mailing list