[PATCH] D18092: Swift Calling Convention: add swifterror attribute

Tue Mar 29 12:27:40 PDT 2016

rjmccall added a comment.

In http://reviews.llvm.org/D18092#386031, @joker.eph wrote:

> OK, but to be sure I understand correctly: the "optimization" is not part of this patch right? I only see plumbing the attribute to the codegen but no use of it.

Correct.  Actually placing the variable in a register at the point of call requires specific backend support that's been separated.

> Might worth mentioning your one sentence description in the attribute description?

Seems like a reasonable request to me.  Manman?

> Also, described as you just did, I wonder if the name couldn't have been more generic than "swifterror" (not that I have a great suggestion to express what you just described though...).

I would be fine with the feature having a more generic name.

http://reviews.llvm.org/D18092