[PATCH] D18092: Swift Calling Convention: add swifterror attribute

Tue Mar 29 12:27:08 PDT 2016

manmanren added a comment.

In http://reviews.llvm.org/D18092#386031, @joker.eph wrote:

> OK, but to be sure I understand correctly: the "optimization" is not part of this patch right? I only see plumbing the attribute to the codegen but no use of it.
>  Might worth mentioning your one sentence description in the attribute description?
>  Also, described as you just did, I wonder if the name couldn't have been more generic than "swifterror" (not that I have a great suggestion to express what you just described though...).

Patches for the swift error attribute are separated into 3 smaller patches. This is the first patch in the series: the second patch is in review as well: http://reviews.llvm.org/D18108. I am going to upload the third patch soon. The second patch handles the target-independent portion of the optimization, and the third patch will update the targets (AArch64, X86 and ARM).

Some of the discussions can be found here:
RFC: Implementing the Swift calling convention in LLVM and Clang
https://groups.google.com/forum/#!topic/llvm-dev/epDd2w93kZ0

http://reviews.llvm.org/D18092