[PATCH] D17633: [X86] Reuse EFLAGS and form LOCKed ops when only user is SETCC.

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 12:14:28 PDT 2016


jfb added a subscriber: jyknight.
jfb added a comment.

I like this overall, but I'd be more comfortable if someone with better x86-fu that I also reviewed it.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:25556
@@ +25555,3 @@
+  // AtomicExpand. Currently, we choose to expand them to cmpxchg if they
+  // have any users. Could we relax that to ignore (icmp x,0) users?
+  switch (LHS->getOpcode()) {
----------------
Note: related to @jyknight's D18201. Probably worth fixing (in a separate patch) once both land.


http://reviews.llvm.org/D17633





More information about the llvm-commits mailing list