[PATCH] D18357: [LTO] Include in .symtab/.dynsym symbols introduced by optimizations

[Davide Italiano via llvm-commits]

davide updated this revision to Diff 51810.
davide added a comment.

Add testcase.


http://reviews.llvm.org/D18357

Files:
  ELF/SymbolTable.cpp
  ELF/Symbols.h
  test/ELF/lto/Inputs/shared.s
  test/ELF/lto/undefined-puts.ll

Index: test/ELF/lto/undefined-puts.ll
===================================================================
--- /dev/null
+++ test/ELF/lto/undefined-puts.ll
@@ -0,0 +1,23 @@
+; REQUIRES: x86
+; RUN: llvm-mc %p/Inputs/shared.s -o %t1.o -filetype=obj -triple=x86_64-unknown-linux
+; RUN: ld.lld %t1.o -o %t1.so -shared
+; RUN: llvm-as %s -o %t2.o
+; RUN: ld.lld %t1.so %t2.o -m elf_x86_64 -o %t
+; RUN: llvm-readobj -dyn-symbols %t | FileCheck %s
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+ at .str = private unnamed_addr constant [6 x i8] c"blah\0A\00", align 1
+
+define i32 @_start() {
+  %str = call i32 (i8*, ...) @printf(i8* getelementptr inbounds ([6 x i8], [6 x i8]* @.str, i32 0, i32 0))
+  ret i32 0
+}
+
+declare i32 @printf(i8*, ...)
+
+; Check that puts symbol is present in the dynamic symbol table.
+; CHECK: DynamicSymbols [
+; CHECK: Symbol {
+; CHECK:    Name: puts@
Index: test/ELF/lto/Inputs/shared.s
===================================================================
--- /dev/null
+++ test/ELF/lto/Inputs/shared.s
@@ -0,0 +1,5 @@
+.globl  printf
+printf:
+
+.globl  puts
+puts:
Index: ELF/Symbols.h
===================================================================
--- ELF/Symbols.h
+++ ELF/Symbols.h
@@ -89,6 +89,8 @@
   bool isInGot() const { return GotIndex != -1U; }
   bool isInPlt() const { return PltIndex != -1U; }
 
+  void setUsedInRegularObj() { IsUsedInRegularObj = true; }
+
   template <class ELFT>
   typename ELFT::uint getVA(typename ELFT::uint Addend = 0) const;
 
@@ -319,7 +321,6 @@
   std::unique_ptr<InputFile> getMember();
 
   void setWeak() { IsWeak = true; }
-  void setUsedInRegularObj() { IsUsedInRegularObj = true; }
 
 private:
   ArchiveFile *File;
Index: ELF/SymbolTable.cpp
===================================================================
--- ELF/SymbolTable.cpp
+++ ELF/SymbolTable.cpp
@@ -108,8 +108,10 @@
   Obj->parse(DummyGroups);
   for (SymbolBody *Body : Obj->getNonLocalSymbols()) {
     Symbol *Sym = insert(Body);
-    if (!Sym->Body->isUndefined() && Body->isUndefined())
+   if (!Sym->Body->isUndefined() && Body->isUndefined()) {
+      Sym->Body->setUsedInRegularObj();
       continue;
+    }
     Sym->Body = Body;
   }
   ObjectFiles.push_back(std::move(Obj));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18357.51810.patch
Type: text/x-patch
Size: 2299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160328/87309493/attachment.bin>