[PATCH] D18490: [PGO] Comment how function pointers for indirect calls are mapped to function names

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 11:46:56 PDT 2016


Right, on it ;)

> On Mar 28, 2016, at 11:46 AM, Xinliang David Li <davidxl at google.com> wrote:
> 
> This should be updated again with the version using C style comment.
> 
> David
> 
> On Mon, Mar 28, 2016 at 11:43 AM, Adam Nemet <anemet at apple.com <mailto:anemet at apple.com>> wrote:
> anemet added inline comments.
> 
> ================
> Comment at: include/llvm/ProfileData/InstrProfData.inc:76
> @@ -75,1 +75,3 @@
>                  llvm::Type::getInt64PtrTy(Ctx)))
> +// This is used to map function pointers for the indirect call targets to
> +// function name hashes during the conversion from raw to merged profile data.
> ----------------
> davidxl wrote:
> > After this is committed, please update the copy of this file in compiler-rt as well.
> Done in r264612.
> 
> 
> Repository:
>   rL LLVM
> 
> http://reviews.llvm.org/D18490 <http://reviews.llvm.org/D18490>
> 
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160328/a58d353b/attachment-0001.html>


More information about the llvm-commits mailing list