<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Right, on it ;)<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 28, 2016, at 11:46 AM, Xinliang David Li <<a href="mailto:davidxl@google.com" class="">davidxl@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">This should be updated again with the version using C style comment.<div class=""><br class=""></div><div class="">David</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Mar 28, 2016 at 11:43 AM, Adam Nemet <span dir="ltr" class=""><<a href="mailto:anemet@apple.com" target="_blank" class="">anemet@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">anemet added inline comments.<br class="">
<span class=""><br class="">
================<br class="">
Comment at: include/llvm/ProfileData/InstrProfData.inc:76<br class="">
@@ -75,1 +75,3 @@<br class="">
</span><span class=""> llvm::Type::getInt64PtrTy(Ctx)))<br class="">
+// This is used to map function pointers for the indirect call targets to<br class="">
+// function name hashes during the conversion from raw to merged profile data.<br class="">
</span>----------------<br class="">
<span class="">davidxl wrote:<br class="">
> After this is committed, please update the copy of this file in compiler-rt as well.<br class="">
</span>Done in r264612.<br class="">
<div class="HOEnZb"><div class="h5"><br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="http://reviews.llvm.org/D18490" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D18490</a><br class="">
<br class="">
<br class="">
<br class="">
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>