[PATCH] D17889: [MachineCopyPropagation] Expose more dead copies across instructions with regmasks

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 11:28:31 PDT 2016


MatzeB added inline comments.

================
Comment at: lib/CodeGen/MachineCopyPropagation.cpp:289-290
@@ +288,4 @@
+      for (SmallSetVector<MachineInstr *, 8>::iterator DI =
+               MaybeDeadCopies.begin();
+           DI != MaybeDeadCopies.end();) {
+        MachineInstr *MaybeDead = *DI;
----------------
junbuml wrote:
> MatzeB wrote:
> > can these two lines get merged to a single one? (Ignore this if they are actually need more than 80 columns when combined).
> Combining these two lines do not require more than 80 columns, but this is what clang-format suggested.
Odd. But feel free to leave it as is then.


http://reviews.llvm.org/D17889





More information about the llvm-commits mailing list