[PATCH] D17889: [MachineCopyPropagation] Expose more dead copies across instructions with regmasks

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 08:37:42 PDT 2016

junbuml added a comment.

Thanks Matthias for the review. 
This will be committed after committing http://reviews.llvm.org/D18281.

Comment at: lib/CodeGen/MachineCopyPropagation.cpp:289-290
@@ +288,4 @@
+      for (SmallSetVector<MachineInstr *, 8>::iterator DI =
+               MaybeDeadCopies.begin();
+           DI != MaybeDeadCopies.end();) {
+        MachineInstr *MaybeDead = *DI;
MatzeB wrote:
> can these two lines get merged to a single one? (Ignore this if they are actually need more than 80 columns when combined).
Combining these two lines do not require more than 80 columns, but this is what clang-format suggested.


More information about the llvm-commits mailing list