[lld] r264111 - [LTO] Keep linkonce_odr symbols when appropriate.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 11:47:50 PDT 2016

On Wed, Mar 23, 2016 at 11:22 AM, Davide Italiano <davide at freebsd.org> wrote:
> On Wed, Mar 23, 2016 at 5:15 AM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>> You only need to change the linkage if you are going to keep it. That is,
>> just before the push_back.
>> You should also handle linkonce in addition to linkonce_odr.
>> On the test, please check the bitcode created by save-temps instead.
>> Cheers,
>> Rafael
> Thank you for your review, Rafael. I committed a couple of patches
> that should address your concerns 1) and 3) and I'm preparing and
> sending review with a patch for 2).

Fat fingering, so this is r264181. Please let me know if have any
other comments.


"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare

More information about the llvm-commits mailing list