[lld] r264111 - [LTO] Keep linkonce_odr symbols when appropriate.

[Sean Silva via llvm-commits]

On Wed, Mar 23, 2016 at 11:22 AM, Davide Italiano via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Wed, Mar 23, 2016 at 5:15 AM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
> > You only need to change the linkage if you are going to keep it. That is,
> > just before the push_back.
> >
> > You should also handle linkonce in addition to linkonce_odr.
> >
> > On the test, please check the bitcode created by save-temps instead.
> >
> > Cheers,
> > Rafael
> >
>
> Thank you for your review, Rafael. I committed a couple of patches
> that should address your concerns 1) and 3)


Please mention specific revisions so that everything is cross-linked in the
archives (to facilitate future software archaeology).

-- Sean Silva


> and I'm preparing and
> sending review with a patch for 2).
>
> --
> Davide
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160323/3fb9604c/attachment.html>