[PATCH] D15525: [GCC] Attribute ifunc support in llvm

Dmitry Polukhin via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 06:51:14 PDT 2016


DmitryPolukhin added a comment.

Eric, that you for looking to the code! I'll split the patch and send first part for review ASAP.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1126
@@ +1125,3 @@
+  else
+    assert(GIS.hasLocalLinkage() && "Invalid alias linkage");
+
----------------
asl wrote:
> Why alias? Shouldn't this be llvm_unreachable?
Local linkage is possible here but I'll update text to reflect that ifunc could be here too.


http://reviews.llvm.org/D15525





More information about the llvm-commits mailing list