[PATCH] D15525: [GCC] Attribute ifunc support in llvm

[Eric Christopher via llvm-commits]

echristo added a comment.

A couple of inline comments for the next patch, but a quick top level comment:

Since we agree that the GlobalIndirectFunc hierarchy is the right way to do this, can you split the patch in two and add that layer of indirection first and then we can add ifunc later to make it easier to see what each side of things is doing?

Also, thank you very much for all of your work and patience here. I really appreciate it.

Thanks!

-eric


================
Comment at: include/llvm-c/Core.h:1790
@@ +1789,3 @@
+ */
+LLVMValueRef LLVMAddIFunc(LLVMModuleRef M, LLVMTypeRef Ty,
+                          LLVMValueRef Resolver, const char *Name);
----------------
We typically add them on demand. I'd rather leave it off for now and we can add it later if it's necessary.

================
Comment at: include/llvm/IR/Module.h:582
@@ +581,3 @@
+
+  ifunc_iterator       ifunc_begin()            { return IFuncList.begin(); }
+  const_ifunc_iterator ifunc_begin() const      { return IFuncList.begin(); }
----------------
No, consistency is fine here, thanks.


http://reviews.llvm.org/D15525