[PATCH] D18248: [ELF] - Set the sh_entsize for mergable sections
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 18 02:56:03 PDT 2016
grimar added inline comments.
Comment at: lld/trunk/ELF/OutputSections.cpp:1223
@@ -1222,2 +1222,3 @@
uintX_t EntSize = S->getSectionHdr()->sh_entsize;
+ this->Header.sh_entsize = EntSize;
> Setting a header value from addSection would be a bit confusing because it runs multiple times. I'd do that in finalize().
Am I missing something, but we dont have access to sh_entsize from finalize. I mean we dont store a list of added sections to take it there.
More information about the llvm-commits