[PATCH] D18248: [ELF] - Set the sh_entsize for mergable sections

[Rui Ueyama via llvm-commits]

Ah, right. I thought that we have a list of input sections, but we actually
don't have that.

On Fri, Mar 18, 2016 at 10:56 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> grimar added inline comments.
>
> ================
> Comment at: lld/trunk/ELF/OutputSections.cpp:1223
> @@ -1222,2 +1222,3 @@
>    uintX_t EntSize = S->getSectionHdr()->sh_entsize;
> +  this->Header.sh_entsize = EntSize;
>
> ----------------
> ruiu wrote:
> > Setting a header value from addSection would be a bit confusing because
> it runs multiple times. I'd do that in finalize().
> Am I missing something, but we dont have access to sh_entsize from
> finalize. I mean we dont store a list of added sections to take it there.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18248
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160318/1c62ea2e/attachment.html>