[PATCH] D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED

Greg Parker via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 17:40:40 PDT 2016


gparker42 added a comment.

`,` acts as `or` for UNSUPPORTED and XFAIL but as `and` for REQUIRES. Also I don't think we want to allow things like `REQUIRES: (a, b) and c`.

I chose the Python syntax for and/or/True/False on the assumption that we might want to allow more Python expressions in the future. (In fact my implementation started that way but it was overkill for my purposes.) Does anyone else have a preference here?


http://reviews.llvm.org/D18185





More information about the llvm-commits mailing list