[PATCH] D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED

NAKAMURA Takumi via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 17:10:42 PDT 2016

chapuni added a subscriber: chapuni.
chapuni added a comment.

LGTM. I feel it might be exaggerated, though. :D

Random thoughts:

- Is ',' actually as same as 'or' ?
- Could we use not words but chars like "!" "&&" there?

Comment at: utils/lit/lit/Test.py:5
@@ -4,1 +4,3 @@
+from BooleanExpression import BooleanExpression
It is failing on py3.

from lit.BooleanExpression import BooleanExpression


More information about the llvm-commits mailing list