[PATCH] D17356: Fix PR26655: Bail out if all the registers of an instruction in a BUNDLE already have the correct kill flag.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 11:42:46 PDT 2016

MatzeB added inline comments.

Comment at: lib/CodeGen/ScheduleDAGInstrs.cpp:1232-1235
@@ -1227,2 +1231,6 @@
+	// If the kill flag is already set on all the operands of the instruction
+	// then bail out.
+	if (NewKillState && KillStateAlreadySet)
+      return;
Indentation is wrong.
I wonder if "NewKillState = false" wouldn't be more consistent than "return", otherwise we will update all operands in the NewKillState==false case, but stop after we encountered an instruction using the register in the NewKillState==true case.


More information about the llvm-commits mailing list