[PATCH] D17356: Fix PR26655: Bail out if all the registers of an instruction in a BUNDLE already have the correct kill flag.

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 09:49:51 PDT 2016

t.p.northover added inline comments.

Comment at: lib/CodeGen/ScheduleDAGInstrs.cpp:1206
@@ -1205,2 +1205,3 @@
   while (Begin != End) {
+    bool KillStateAlreadySet = true;
     for (MachineOperand &MO : (--End)->operands()) {
I think this goes wrong if the last instruction in the bundle doesn't kill Reg: the MachineOperand loop never clears KillStateAlready set and so we bail.

Perhaps a more suggestive name for this variable would be `SeenKill`.


More information about the llvm-commits mailing list