[PATCH] D18183: [ELF] - -pie/--pic-executable option implemented

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 09:09:17 PDT 2016

ruiu added inline comments.

Comment at: ELF/Driver.cpp:150-151
@@ +149,4 @@
+      error("-shared and -pie may not be used together");
+    if (Config->Static)
+      error("-static and -pie may not be used together");
+  }
ruiu wrote:
> Please remove this code unless you have a valid reason to do so.
Adding code which you cannot justify is a bad idea. "Leaving it as is" means not adding that code because that code didn't exist before. Add this piece of code when you find you actually need it.


More information about the llvm-commits mailing list