[PATCH] D18183: [ELF] - -pie/--pic-executable option implemented

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 09:03:41 PDT 2016


grimar added inline comments.

================
Comment at: ELF/Driver.cpp:148-149
@@ +147,4 @@
+  if (Config->Pie) {
+    if (Config->Shared)
+      error("-shared and -pie may not be used together");
+    if (Config->Static)
----------------
ruiu wrote:
> I think this is also something that we are checking for errors too eagerly. -shared implies -pie, so they are not incompatible. It is better to ignore this combination.
-shared implies pic, but not -pie. As pie is Position Independent Executable. So I can't agree here. Gold do the same check.


http://reviews.llvm.org/D18183





More information about the llvm-commits mailing list