[PATCH] D18190: [ELF] - Error out when R_X86_64_PC32/R_X86_64_32 are used against preemptible symbol when linking shared object.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 08:37:25 PDT 2016

On Wed, Mar 16, 2016 at 8:32 AM, George Rimar <grimar at accesssoftek.com>

> grimar added a comment.
> In http://reviews.llvm.org/D18190#376427, @ruiu wrote:
> > Ah, gotcha. So this change would break the existing test for r259831
> because it would now fail because of "recompile with -fPIC" error, so you
> had to update it.
> >
> > But you don't have to update the binary. Remove "-shared" from
> llvm33-rela-outside-group.s.
> I was not familar with that test and commit. If you think we can just
> remove -shared, lets do that separately, before checking in this one ?

If you are not familiar with that test, then please take time to understand
it. You were about to modify the input to that particular test. If you
don't understand what you are doing, you may be changing the test in such a
way that it would make no longer sense.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160316/50d9af91/attachment.html>

More information about the llvm-commits mailing list