[PATCH] D18190: [ELF] - Error out when R_X86_64_PC32/R_X86_64_32 are used against preemptible symbol when linking shared object.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 08:32:19 PDT 2016

grimar added a comment.

In http://reviews.llvm.org/D18190#376427, @ruiu wrote:

> Ah, gotcha. So this change would break the existing test for r259831 because it would now fail because of "recompile with -fPIC" error, so you had to update it.
> But you don't have to update the binary. Remove "-shared" from llvm33-rela-outside-group.s.

I was not familar with that test and commit. If you think we can just remove -shared, lets do that separately, before checking in this one ?


More information about the llvm-commits mailing list