[PATCH] D18135: ELF: Move initSymbols to Symbols.cpp.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 00:59:55 PDT 2016

grimar added a comment.

In http://reviews.llvm.org/D18135#374658, @ruiu wrote:

> Callers of the initializer should not take care of the details whether the function works on ELFT-specialized objects or not.

That is arguable. Here it do excessive work when initializing something that is not used. That has no impact on perfomance but actually confuses, makes code reader to think that these symbols are required somehow when them are not.

I would agree with Rafael here to hold it if possible until we see any other initXXX function.


More information about the llvm-commits mailing list