[PATCH] D18135: ELF: Move initSymbols to Symbols.cpp.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 16:53:46 PDT 2016


I would probably hold this until we need a second initSomething function.

Cheers,
Rafael


On 14 March 2016 at 10:41, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> ruiu added a comment.
>
> Sorry, I replied to a different thread.
>
> So, it's ecause that Symbol.cpp needs to initialize symbols for each ELF type is an internal detail of the file. initSymbol, or in general, init<filename> is the initializer function for a file. Callers of the initializer should not take care of the details whether the function works on ELFT-specialized objects or not.
>
>
> http://reviews.llvm.org/D18135
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list