Don't invent names for STT_SECTION symbols.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 00:48:24 PDT 2016


>On 12 March 2016 at 12:33, George Rimar <grimar at accesssoftek.com> wrote:
>>> We should just copy the symbol names with -r.
>>> ...
>>>-        // That can happen if creating relocatable output.
>>>-        if (Sym.getType() == STT_SECTION)
>>>-          SymName = Section->getSectionName();
>>
>> Why not ?
>
>Because we don't need to. If the producer wants to give a section
>symbol a name, it can do it and we will keep it. If whatever produced
>the .o decided to not name it, it is not the linker's job to change
>that decision.
>
>Cheers,
>Rafael

Fair enough.

George.


More information about the llvm-commits mailing list