[lld] r262846 - Do not use "default" for a fully-covered switch.

[Sean Silva via llvm-commits]

It looks like this is causing warnings after all:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/1415/steps/build/logs/warnings%20%281%29

Can you add an llvm_unreachable? As per
http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
I think the right place to put it is after the switch.

-- Sean Silva

On Mon, Mar 7, 2016 at 11:06 AM, Rui Ueyama via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: ruiu
> Date: Mon Mar  7 13:06:14 2016
> New Revision: 262846
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262846&view=rev
> Log:
> Do not use "default" for a fully-covered switch.
>
> Modified:
>     lld/trunk/ELF/InputFiles.cpp
>
> Modified: lld/trunk/ELF/InputFiles.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=262846&r1=262845&r2=262846&view=diff
>
> ==============================================================================
> --- lld/trunk/ELF/InputFiles.cpp (original)
> +++ lld/trunk/ELF/InputFiles.cpp Mon Mar  7 13:06:14 2016
> @@ -416,12 +416,12 @@ bool BitcodeFile::classof(const InputFil
>
>  static uint8_t getGvVisibility(const GlobalValue *GV) {
>    switch (GV->getVisibility()) {
> +  case GlobalValue::DefaultVisibility:
> +    return STV_DEFAULT;
>    case GlobalValue::HiddenVisibility:
>      return STV_HIDDEN;
>    case GlobalValue::ProtectedVisibility:
>      return STV_PROTECTED;
> -  default:
> -    return STV_DEFAULT;
>    }
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160308/7ea7c99f/attachment.html>