<div dir="ltr">It looks like this is causing warnings after all: <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/1415/steps/build/logs/warnings%20%281%29">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/1415/steps/build/logs/warnings%20%281%29</a><div><br></div><div>Can you add an llvm_unreachable? As per <a href="http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations">http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations</a> I think the right place to put it is after the switch.</div><div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 11:06 AM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Mon Mar  7 13:06:14 2016<br>
New Revision: 262846<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262846&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262846&view=rev</a><br>
Log:<br>
Do not use "default" for a fully-covered switch.<br>
<br>
Modified:<br>
    lld/trunk/ELF/InputFiles.cpp<br>
<br>
Modified: lld/trunk/ELF/InputFiles.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=262846&r1=262845&r2=262846&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=262846&r1=262845&r2=262846&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputFiles.cpp (original)<br>
+++ lld/trunk/ELF/InputFiles.cpp Mon Mar  7 13:06:14 2016<br>
@@ -416,12 +416,12 @@ bool BitcodeFile::classof(const InputFil<br>
<br>
 static uint8_t getGvVisibility(const GlobalValue *GV) {<br>
   switch (GV->getVisibility()) {<br>
+  case GlobalValue::DefaultVisibility:<br>
+    return STV_DEFAULT;<br>
   case GlobalValue::HiddenVisibility:<br>
     return STV_HIDDEN;<br>
   case GlobalValue::ProtectedVisibility:<br>
     return STV_PROTECTED;<br>
-  default:<br>
-    return STV_DEFAULT;<br>
   }<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>