[llvm] r262531 - [MBP] Remove overly verbose debug output

[Philip Reames via llvm-commits]

Because it didn't seem to add any information, was misleading in the 
context of the other surrounding output, and only present in 2 of many 
similar cases.  If you disagree, feel free to revert.  It's not worth 
the time to discuss in depth.

Philip

On 03/02/2016 04:21 PM, Xinliang David Li wrote:
> Why is it considered over verbose?
>
> David
>
> On Wed, Mar 2, 2016 at 2:40 PM, Philip Reames via llvm-commits 
> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>
>     Author: reames
>     Date: Wed Mar  2 16:40:51 2016
>     New Revision: 262531
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=262531&view=rev
>     Log:
>     [MBP] Remove overly verbose debug output
>
>
>     Modified:
>         llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp
>
>     Modified: llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp
>     URL:
>     http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp?rev=262531&r1=262530&r2=262531&view=diff
>     ==============================================================================
>     --- llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp (original)
>     +++ llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp Wed Mar  2
>     16:40:51 2016
>     @@ -403,8 +403,6 @@ MachineBlockPlacement::selectBestSuccess
>          } else {
>            BlockChain *SuccChain = BlockToChain[Succ];
>            if (SuccChain == &Chain) {
>     -        DEBUG(dbgs() << "    " << getBlockName(Succ)
>     -                     << " -> Already merged!\n");
>              SkipSucc = true;
>            } else if (Succ != *SuccChain->begin()) {
>              DEBUG(dbgs() << "    " << getBlockName(Succ) << " -> Mid
>     chain!\n");
>     @@ -524,10 +522,9 @@ MachineBasicBlock *MachineBlockPlacement
>        BlockFrequency BestFreq;
>        for (MachineBasicBlock *MBB : WorkList) {
>          BlockChain &SuccChain = *BlockToChain[MBB];
>     -    if (&SuccChain == &Chain) {
>     -      DEBUG(dbgs() << "    " << getBlockName(MBB) << " -> Already
>     merged!\n");
>     +    if (&SuccChain == &Chain)
>            continue;
>     -    }
>     +
>          assert(SuccChain.LoopPredecessors == 0 && "Found
>     CFG-violating block");
>
>          BlockFrequency CandidateFreq = MBFI->getBlockFreq(MBB);
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160302/874e78fb/attachment.html>