<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Because it didn't seem to add any information, was misleading in the
context of the other surrounding output, and only present in 2 of
many similar cases. If you disagree, feel free to revert. It's not
worth the time to discuss in depth.<br>
<br>
Philip<br>
<br>
<div class="moz-cite-prefix">On 03/02/2016 04:21 PM, Xinliang David
Li wrote:<br>
</div>
<blockquote
cite="mid:CALRgJCPNwQkgLnepa3bVinUb7WBXdb=pkje+TKp=A8R58mnQfA@mail.gmail.com"
type="cite">
<div dir="ltr">Why is it considered over verbose?
<div><br>
</div>
<div>David</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Mar 2, 2016 at 2:40 PM, Philip
Reames via llvm-commits <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
reames<br>
Date: Wed Mar 2 16:40:51 2016<br>
New Revision: 262531<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=262531&view=rev"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262531&view=rev</a><br>
Log:<br>
[MBP] Remove overly verbose debug output<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp?rev=262531&r1=262530&r2=262531&view=diff"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp?rev=262531&r1=262530&r2=262531&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp
(original)<br>
+++ llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp Wed
Mar 2 16:40:51 2016<br>
@@ -403,8 +403,6 @@ MachineBlockPlacement::selectBestSuccess<br>
} else {<br>
BlockChain *SuccChain = BlockToChain[Succ];<br>
if (SuccChain == &Chain) {<br>
- DEBUG(dbgs() << " " <<
getBlockName(Succ)<br>
- << " -> Already merged!\n");<br>
SkipSucc = true;<br>
} else if (Succ != *SuccChain->begin()) {<br>
DEBUG(dbgs() << " " <<
getBlockName(Succ) << " -> Mid chain!\n");<br>
@@ -524,10 +522,9 @@ MachineBasicBlock
*MachineBlockPlacement<br>
BlockFrequency BestFreq;<br>
for (MachineBasicBlock *MBB : WorkList) {<br>
BlockChain &SuccChain = *BlockToChain[MBB];<br>
- if (&SuccChain == &Chain) {<br>
- DEBUG(dbgs() << " " <<
getBlockName(MBB) << " -> Already merged!\n");<br>
+ if (&SuccChain == &Chain)<br>
continue;<br>
- }<br>
+<br>
assert(SuccChain.LoopPredecessors == 0 &&
"Found CFG-violating block");<br>
<br>
BlockFrequency CandidateFreq =
MBFI->getBlockFreq(MBB);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>