[llvm] r262338 - [AMDGPU] Fix build warnings.

[Christian König via llvm-commits]

It would still be better to remove those lines now and add them back 
when they are used.

This way you don't accidentally leave dead code in here when the patch 
who makes use of it never lands.

Christian.

Am 01.03.2016 um 16:56 schrieb Haustov, Nikolay via llvm-commits:
>
> The warning was about unused static function. Valery has pending 
> changes that will use these decoders, so they will get used soon.
>
> Nikolay
>
> *From:*David Blaikie [mailto:dblaikie at gmail.com]
> *Sent:* Tuesday, March 1, 2016 6:51 PM
> *To:* Haustov, Nikolay
> *Cc:* llvm-commits
> *Subject:* Re: [llvm] r262338 - [AMDGPU] Fix build warnings.
>
> What was the warning? And is there a reason we want to leave those 
> lines in the file, though commented out (generally we just delete dead 
> code)
>
> On Mar 1, 2016 6:55 AM, "Nikolay Haustov via llvm-commits" 
> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>
> Author: nhaustov
> Date: Tue Mar  1 08:50:59 2016
> New Revision: 262338
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262338&view=rev
> Log:
> [AMDGPU] Fix build warnings.
>
> Modified:
> llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
>
> Modified: llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
> URL: 
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp?rev=262338&r1=262337&r2=262338&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp 
> (original)
> +++ llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp 
> Tue Mar  1 08:50:59 2016
> @@ -66,12 +66,12 @@ DECODE_OPERAND(VReg_64)
>  DECODE_OPERAND(VReg_96)
>  DECODE_OPERAND(VReg_128)
>
> -DECODE_OPERAND(SGPR_32)
> +//DECODE_OPERAND(SGPR_32)
>  DECODE_OPERAND(SReg_32)
>  DECODE_OPERAND(SReg_64)
>  DECODE_OPERAND(SReg_128)
>  DECODE_OPERAND(SReg_256)
> -DECODE_OPERAND(SReg_512)
> +//DECODE_OPERAND(SReg_512)
>
>  #define GET_SUBTARGETINFO_ENUM
>  #include "AMDGPUGenSubtargetInfo.inc"
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160301/4d95318b/attachment.html>