<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">It would still be better to remove
those lines now and add them back when they are used.<br>
<br>
This way you don't accidentally leave dead code in here when the
patch who makes use of it never lands.<br>
<br>
Christian.<br>
<br>
Am 01.03.2016 um 16:56 schrieb Haustov, Nikolay via llvm-commits:<br>
</div>
<blockquote
cite="mid:AAB52FAA5D2E204BB12B32EC753DA5F6369881FB@storexdag04.amd.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:2.0cm 42.5pt 2.0cm 3.0cm;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"
lang="EN-US">The warning was about unused static function.
Valery has pending changes that will use these decoders, so
they will get used soon.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"
lang="EN-US">Nikolay<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""
lang="EN-US">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""
lang="EN-US"> David Blaikie [<a class="moz-txt-link-freetext" href="mailto:dblaikie@gmail.com">mailto:dblaikie@gmail.com</a>]
<br>
<b>Sent:</b> Tuesday, March 1, 2016 6:51 PM<br>
<b>To:</b> Haustov, Nikolay<br>
<b>Cc:</b> llvm-commits<br>
<b>Subject:</b> Re: [llvm] r262338 - [AMDGPU] Fix build
warnings.<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p>What was the warning? And is there a reason we want to leave
those lines in the file, though commented out (generally we
just delete dead code)<o:p></o:p></p>
<div>
<p class="MsoNormal">On Mar 1, 2016 6:55 AM, "Nikolay Haustov
via llvm-commits" <<a moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>>
wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: nhaustov<br>
Date: Tue Mar 1 08:50:59 2016<br>
New Revision: 262338<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=262338&view=rev"
target="_blank">
http://llvm.org/viewvc/llvm-project?rev=262338&view=rev</a><br>
Log:<br>
[AMDGPU] Fix build warnings.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp<br>
<br>
Modified:
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp?rev=262338&r1=262337&r2=262338&view=diff"
target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp?rev=262338&r1=262337&r2=262338&view=diff</a><br>
==============================================================================<br>
---
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
(original)<br>
+++
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
Tue Mar 1 08:50:59 2016<br>
@@ -66,12 +66,12 @@ DECODE_OPERAND(VReg_64)<br>
DECODE_OPERAND(VReg_96)<br>
DECODE_OPERAND(VReg_128)<br>
<br>
-DECODE_OPERAND(SGPR_32)<br>
+//DECODE_OPERAND(SGPR_32)<br>
DECODE_OPERAND(SReg_32)<br>
DECODE_OPERAND(SReg_64)<br>
DECODE_OPERAND(SReg_128)<br>
DECODE_OPERAND(SReg_256)<br>
-DECODE_OPERAND(SReg_512)<br>
+//DECODE_OPERAND(SReg_512)<br>
<br>
#define GET_SUBTARGETINFO_ENUM<br>
#include "AMDGPUGenSubtargetInfo.inc"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>