[PATCH] D17677: DAGCombiner: Turn extract of bitcasted integer into truncate

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 11:44:18 PST 2016


arsenm added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12248
@@ +12247,3 @@
+    if (BCSrc.getValueType().isScalarInteger())
+      return DAG.getNode(ISD::TRUNCATE, SDLoc(InVec), NVT, BCSrc);
+  }
----------------
ab wrote:
> Not a big deal, but SDLoc(N) seems more appropriate, no?
That seems more right, although in situations like this I'm not sure if it's supposed to be the source's


http://reviews.llvm.org/D17677





More information about the llvm-commits mailing list