[PATCH] D17677: DAGCombiner: Turn extract of bitcasted integer into truncate

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 11:10:41 PST 2016


ab added a subscriber: ab.
ab accepted this revision.
ab added a reviewer: ab.
ab added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12248
@@ +12247,3 @@
+    if (BCSrc.getValueType().isScalarInteger())
+      return DAG.getNode(ISD::TRUNCATE, SDLoc(InVec), NVT, BCSrc);
+  }
----------------
Not a big deal, but SDLoc(N) seems more appropriate, no?


http://reviews.llvm.org/D17677





More information about the llvm-commits mailing list