[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 28 04:49:00 PST 2016

grimar added a comment.

I placed R_AARCH64_TLSDESC after R_AARCH64_JUMP_SLOT ones. And also placed .got.plt entries after common ones for these relocations.
These changes together resolved the issues I observed, helloworld now works fine for me. I hope it is enough for initial version of patch and I am going to update it with this changes soon.

In http://reviews.llvm.org/D16201#363173, @zatrazz wrote:

> I am also not sure about the position of the TLSDESC relocation, I will check that.
> I also noted that the patches does not create dynamic R_AARCH64_TLSDESC relocations against local symbols.

I`ll check that. But I think that can be fixed in a different patch(s). Changes I wrote about above IMO a good point to commit as this  patch is already large.

So I have plans to update it tommorrow.


More information about the llvm-commits mailing list