[PATCH] D17676: Add some minimal portability code paths for PS4.
David Li via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 27 14:05:29 PST 2016
davidxl added inline comments.
Comment at: lib/profile/InstrProfilingPort.h:29
@@ -28,1 +28,3 @@
+#define COMPILER_RT_GETHOSTNAME(Name, Len) (-1)
> Should we do something about `COMPILER_RT_HAS_UNAME`? (Both here and on the Windows case)
> Or simply get rid of it, it it's there just for one case...
The macro is needed to enable definition of the GetHostName wrapper (to uname). For PS4 there is no need to define it.
More information about the llvm-commits