[PATCH] D17676: Add some minimal portability code paths for PS4.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 27 12:07:17 PST 2016

filcab added a comment.

Thanks for working on this. I'll ping you to talk about the `%run`.

Comment at: lib/profile/InstrProfilingPort.h:29
@@ -28,1 +28,3 @@
+#elif defined(__PS4__)
+#define COMPILER_RT_GETHOSTNAME(Name, Len) (-1)
Should we do something about `COMPILER_RT_HAS_UNAME`? (Both here and on the Windows case)
Or simply get rid of it, it it's there just for one case...

Comment at: lib/profile/InstrProfilingUtil.h:18
@@ +17,3 @@
+#if __PS4__
+static inline char *getenv(const char *name) { return 0; }
+#endif /* #if __PS4__ */
Use `NULL`?


More information about the llvm-commits mailing list