[PATCH] D17587: [FileCheck] Abort if -NOT is combined with another suffix

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 11:54:57 PST 2016

probinson added a comment.

In http://reviews.llvm.org/D17587#362059, @arsenm wrote:

> The -NOT to exclude some intermixed instructions acts as a barrier between the sections of CHECK-DAGs.

Okay, that's how it's documented to work.  And some experimentation suggests that despite the documentation, that's not actually how it works.  Huh.
A CHECK-DAG followed by CHECK-NOT causes the CHECK-DAG match to bound the range for the CHECK-NOT.
However, a CHECK-NOT followed by a CHECK-DAG does not cause the CHECK-DAG to bound the range of the CHECK-NOT.

That feels more like a bug in FileCheck, than a mistake made by the test-writer?  In this patch I'm trying to avoid test-writer mistakes.


More information about the llvm-commits mailing list