[PATCH] D17587: [FileCheck] Abort if -NOT is combined with another suffix

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 11:28:53 PST 2016

arsenm added a comment.

In http://reviews.llvm.org/D17587#362039, @probinson wrote:

> In http://reviews.llvm.org/D17587#362018, @arsenm wrote:
> > Another good thing to catch would be CHECK-DAGs mixed with CHECK-NOTs, which does not work as expected
> What are your expectations?

I often want to check a sequence of N instructions are in any order, but also excluding others between them. IIRC, the -NOT may just be a sub-problem of multiple identical CHECK-DAGs.

Something like
; CHECK-DAG: add
; CHECK-DAG: sub
; CHECK-DAG: add

Will pass with only 1 add in the sequence. The -NOT to exclude some intermixed instructions acts as a barrier between the sections of CHECK-DAGs.


More information about the llvm-commits mailing list