[PATCH] D16173: [ThinLTO] Do not mark linkonce symbols as preempted in ThinLTO backends

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 09:11:17 PST 2016

tejohnson added a comment.

In http://reviews.llvm.org/D16173#361067, @rafael wrote:

> Just before the code you changed there is an area were we patch gold's decision. Would it work to just add
> if (options::thinlto && (Resolution ==  LDPR_PREVAILING_DEF_IRONLY_EXP || Resolution == LDPR_PREVAILING_DEF_IRONLY))
>   Resolution =  LDPR_PREVAILING_DEF;
> If so, I think that is better.
> LGTM either way.

I like your suggestion, it is cleaner. Implemented and will upload new patch here. Will also update description in Phab and in git before I commit. Note that this is dependent on the gold threading patch http://reviews.llvm.org/D15390 (for the test case to work), so I will wait to commit this until after that goes in (hopefully very very soon! =) ).

Comment at: test/tools/gold/X86/thinlto_linkonceresolution.ll:14
@@ +13,3 @@
+; RUN:     -o %t3.o %t2.o %t.o
+; RUN: llvm-nm %t3.o | FileCheck %s
rafael wrote:
> if you pass save-temps you should be able to more directly test the linkage change, no?
Good idea, adding that.


More information about the llvm-commits mailing list