[PATCH] D16173: [ThinLTO] Do not mark linkonce symbols as preempted in ThinLTO backends

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 15:07:14 PST 2016

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

Just before the code you changed there is an area were we patch gold's decision. Would it work to just add

if (options::thinlto && (Resolution ==  LDPR_PREVAILING_DEF_IRONLY_EXP || Resolution == LDPR_PREVAILING_DEF_IRONLY))

  Resolution =  LDPR_PREVAILING_DEF;

If so, I think that is better.

LGTM either way.

Comment at: test/tools/gold/X86/thinlto_linkonceresolution.ll:14
@@ +13,3 @@
+; RUN:     -o %t3.o %t2.o %t.o
+; RUN: llvm-nm %t3.o | FileCheck %s
if you pass save-temps you should be able to more directly test the linkage change, no?


More information about the llvm-commits mailing list