[PATCH] D17129: [Compiler-rt][MSan] fix param_tls_limit test

Mohit Bhakkad via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 02:17:28 PST 2016

mohit.bhakkad added a comment.

In http://reviews.llvm.org/D17129#354099, @eugenis wrote:

> Maybe you can define PARTIAL_OVERFLOW() for the arguments that start in param-tls and end outside of it. It would be defined the same as OVERFLOW() on x86, and the same as NO_POISON() on other platforms, resulting in a slightly weaker test.

Hi @eugenis, I didn't understood your suggestion clearly.
I understand OVERFLOW() and NO_POISON() will have same definition.

In this revision, I initiialized arguments that start in param-tls and end outside of it upto till param-tls size, so they will match condition of OVERFLOW().
Without initialing, they will match NO_OVERFLOW in archs other than x86.

What will be functionality of PARTIAL_OVERFLOW(), and if you want to keep same test for all archs, than should we initialize overflow arguments ?



More information about the llvm-commits mailing list